NoQ added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:539
-SVal SValBuilder::evalCast(SVal V, QualType CastTy, QualType OriginalTy) {
- CastTy = Context.getCanonicalType(CastTy);
- OriginalTy = Context.getCanonicalType(OriginalTy);
- if (CastTy == OriginalTy)
+// In case when `OriginalTy.isNull() == true` we cast `V` less accurately.
+SVal SValBuilder::evalCast(SVal V, QualType CastTy,
----------------
This is one of the most important APIs of `SValBuilder`, alongside
`evalBinOp()`. The newly added behavior is definitely obscure and needs
explaining. So i think you should move this comment into the header, turn it
into a doxygen comment, and elaborate what "less accurately" actually means
here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96090/new/
https://reviews.llvm.org/D96090
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
