courbet added inline comments.
================
Comment at: clang-tidy/google/GoogleTidyModule.cpp:40
@@ -38,1 +39,3 @@
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+ CheckFactories.registerCheck<DefaultArgumentsCheck>(
+ "google-default-arguments");
----------------
hokein wrote:
> Please keep the alphabetical order.
I think the script auto-generated that, but done.
================
Comment at: docs/clang-tidy/checks/google-default-arguments.rst:6
@@ +5,3 @@
+
+Checks that default parameters are not given for virtual methods.
+
----------------
hokein wrote:
> I'm a little confused about the words here. Indeed, the
> `google-default-arguments` checks the default parameter given for virtual
> methods.
>
Right, I got mixed up in the terminology: the default argument is given as an
initializer for the parameter declaration.
http://reviews.llvm.org/D19534
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
