abidh added a comment.
In D98113#2609027 <https://reviews.llvm.org/D98113#2609027>, @jrtc27 wrote:
> One thing that is currently rather ugly about BareMetal is that it ignores
> the AddArch argument. Once you have a sysroot, the architecture suffix is
> rather unnecessary, and given compiler-rt uses
> LLVM_ENABLE_PER_TARGET_RUNTIME_DIR to decide both whether to add a suffix and
> whether to add `lib/${OS}` to the install path, that means you can't nicely
> point compiler-rt at the sysroot as the install directory (well, unless you
> do something like make COMPILER_RT_OUTPUT_DIR point at the sysroot not the
> libdir and set COMPILER_RT_OS_DIR to `.` (or maybe the empty string also
> works)).
Agree that setting the compiler-rt installation directory is not ideal. I
remember I ended up doing some post installation steps to make sure that
libraries were in right folder.
Regarding this patch, currently Baremetal toolchain looks for compiler-rt in a
multilib specific directory. Does that not solve the problem of finding
compiler-rt for any given arch/abi combination automatically?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98113/new/
https://reviews.llvm.org/D98113
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
