ioeric added inline comments.

================
Comment at: include-fixer/IncludeFixer.h:34-35
@@ -33,3 +33,4 @@
   IncludeFixerActionFactory(
-      XrefsDB &Xrefs, std::vector<clang::tooling::Replacement> &Replacements,
+      XrefsDBManager &XrefsDBMgr,
+      std::vector<clang::tooling::Replacement> &Replacements,
       bool MinimizeIncludePaths = true);
----------------
klimek wrote:
> That seems unexpected. Why is the XrefsDBManager in the business of doing 
> SymbolInfo -> include path mappings?
Since the mapping was done in XrefsDB before, I kept the way it was. Migrating 
SymbolInfo -> Include path mappings into IncludeFixer will be the next step, 
and I'll need to discuss with Ben about where exactly we want to place it.


http://reviews.llvm.org/D19869



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to