Xiangling_L added inline comments.
================ Comment at: clang/include/clang/Basic/LLVM.h:71 using llvm::SmallString; - using llvm::SmallVector; - using llvm::SmallVectorImpl; ---------------- It's my bad to not wait for a build finished before updating the patch, I saw a lot of build failures as the following that seems related to the deletion here: ``` /data/xling/wyvern/master-external/llvm-project/clang/include/clang/Basic/Module.h:222:3: error: no template named 'SmallVector'; did you mean 'llvm::SmallVector'? SmallVector<UnresolvedHeaderDirective, 1> UnresolvedHeaders; ^~~~~~~~~~~ llvm::SmallVector /data/xling/wyvern/master-external/llvm-project/clang/include/clang/Basic/LLVM.h:38:42: note: 'llvm::SmallVector' declared here template<typename T, unsigned N> class SmallVector; ^ ``` I will update the patch accordingly after I have a successful build and run the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits