mizvekov added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970
 def note_defaulted_comparison_calls_deleted : Note<
   "defaulted %0 is implicitly deleted because it would invoke a deleted "
   "comparison function%select{| for member %2| for base class %2}1">;
----------------
rsmith wrote:
> Would it be useful to apply the same diagnostic improvement to this 
> diagnostic too? (Genuine question: I *think* we'll attach a note pointing to 
> the deleted function in this case, which would probably make the "for T" part 
> just be noise, but I've not checked.)
Yeah I thought about checking other errors for similar improvements. It's on my 
list to check that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97990/new/

https://reviews.llvm.org/D97990

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to