steveire added a comment. In D93164#2624690 <https://reviews.llvm.org/D93164#2624690>, @thakis wrote:
> A few more high-level questions: > > - What's the point of the intermediary json file? Why not generate the final > c++ directly? (As far as I can tell, this wasn't discussed during the review > yet) It came up in review earlier: https://reviews.llvm.org/D93164#2456181 > - Do we need to generate code for this at all? Could this be done via xmacros > or tablegen? Can you say more? Would this require generating the declarations in `include/clang/AST`? It sounds like a large maintenance burden, but maybe I'm missing something. > Having a bespoke custom python -> json -> python -> c++ pipeline here seems > like it's fairly different from how the rest of clang does things, and it > seems like it duplicates some of the existing tooling we have here. > > (Having said that, I'm no code owner here -- @rsmith is. Maybe he has an > opinion.) > > Lower-level: Did you see all the comments on > https://reviews.llvm.org/rGd627a27d264b47eda3f15f086ff419dfe053ebf7 ? This > relanded with them unaddressed. Please address them in a follow-up. (Sorry > for leaving the comments on the commit instead of the review!) Done, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
