gulfem added inline comments.
================
Comment at: llvm/utils/gn/secondary/llvm/lib/Transforms/Utils/BUILD.gn:64
"PromoteMemoryToRegister.cpp",
+ "RelLookupTableConverter.cpp"
"SSAUpdater.cpp",
----------------
thakis wrote:
> leonardchan wrote:
> > Good that you added this, but I think Nico has a bot that automatically
> > updates these BUILD.gn files so manually updating them may not be necessary.
> Please don't touch gn files unless you use them. Simple file additions in
> cmake files are synced automatically http://github.com/llvmgnsyncbot
>
> You forgot to add the trailing comma and now I had to fix it up manually
> instead of doing nothing :P
Sorry about that Niko. I can fix it, so you don't need to do anything.
Leo actually pointed that out, but I thought that manually changing it won't do
any harm.
Apparently it did though!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94355/new/
https://reviews.llvm.org/D94355
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
