nick added inline comments.

================
Comment at: clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp:301
+TEST_F(RegistryTest, CXXBaseSpecifier) {
+  // TODO: rewrite with top-level cxxBaseSpecifier matcher when available
+  DeclarationMatcher ClassHasAnyDirectBase =
----------------
steveire wrote:
> @nick Is this implemented in another MR? I don't see anything in your list of 
> revisions. I think this is reasonable as is, but wondering if you intend to 
> implement the top-level support too.
The patch had some of the top-level matcher parts, but it cut them off when 
rebased. I have no need in it myself and I am not sure there is any kind of use 
for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69218/new/

https://reviews.llvm.org/D69218

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to