dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:218 -TARGET_BUILTIN(__builtin_wasm_eq_i64x2, "V2LLiV2LLiV2LLi", "nc", "simd128") - ---------------- Is the builtin/intrinsic wrong now? Or just not necessary because we can use builtin operators? ================ Comment at: llvm/test/CodeGen/WebAssembly/simd-select.ll:313 ; CHECK-NEXT: # fallthrough-return <2 x i64> %x, <2 x i64> %y) { %c = icmp slt <2 x i64> %a, %b ---------------- pre-existing, but is there a reason why the CHECKs here are in the middle of the IR function signature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99623/new/ https://reviews.llvm.org/D99623 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits