NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
I don't see any further bugs so I think this is good to go! I think you should separate out the NFC / debugging facility changes before committing. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:294 + + SmallString<128> Msg; + llvm::raw_svector_ostream Out(Msg); ---------------- 128 is too much imho :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
