ASDenysPetrov added a comment. @steakhal thanks for the approval.
================ Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:564-565 } - - llvm_unreachable("Unknown SVal kind"); } ---------------- steakhal wrote: > You probably don't want to remove this. The same applies to similar ones. Yep. I'd keep it here, beacuse of compiler warnings of no-return function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits