tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Driver/ToolChains/HIP.cpp:115 std::string OffloadKind = "hip"; + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) + OffloadKind = OffloadKind + "v4"; ---------------- Should it be an error if we pass `-mcode-object-version=99` ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99235/new/ https://reviews.llvm.org/D99235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
