SaurabhJha added a comment. Hey Florian and John,
Thanks for your reviews so far. Just checked the build. Addressed all previous comments and the build is looking good too except for one thing. For open cl tests, it is failing with this curious `error: initializer element is not a compile-time constant` which I am still not sure how to debug. I tried to debug `Clang.SemaOpenCL::sampler_t_overload.cl` by moving the definition of `MatrixCast` in `OperationKinds.def` to below the definition of `IntToOCLSampler`. That made it work for `sampler_overload` but then the new matrix cast tests started failing. Will give it another shot today. If you have any thoughts on this, let me know. Saurabh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
