nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land.
================ Comment at: llvm/include/llvm/IR/Function.h:156 + static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, + unsigned AddrSpace, ---------------- Perhaps a comment that this "creates functions with module level attributes applied at the function level. Use this when synthesizing new functions that might have attributes that depend on module level attributes that would have been set by command line flags" or such. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100251/new/ https://reviews.llvm.org/D100251 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
