JonChesterfield added a comment. New tests look good to me, thanks.
================ Comment at: clang/include/clang/Driver/Options.td:922 +def amdgpu_arch_tool_EQ : Joined<["--"], "amdgpu-arch-tool=">, Group<i_Group>, + HelpText<"Path to amdgpu_arch tool, used for detecting AMD GPU arch in the system.">; def rocm_device_lib_path_EQ : Joined<["--"], "rocm-device-lib-path=">, Group<Link_Group>, ---------------- > Path to tool used for detecting AMD GPU arch in the system. ? ================ Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:105 + /// if unable to find one. Location of amdgpu_arch tool can be optionally + /// provided as --amdgpu-arch-tool-path=/path/to/amdgpu_arch + SmallString<8> getSystemGPUArch(const llvm::opt::ArgList &Args) const; ---------------- Comment out of date. Possibly delete sentence starting Location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
