skan accepted this revision.
skan added inline comments.
================
Comment at: llvm/lib/Support/X86TargetParser.cpp:176
FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC |
FeatureXSAVES | FeatureSGX;
// SkylakeServer inherits all SkylakeClient features except SGX.
----------------
craig.topper wrote:
> skan wrote:
> > Shouldn't the FeatureSGX be removed here?
> That would change the frontend behavior which would require a wider
> discussion. My suggestion was only to change the backend behavior since there
> was nothing testable with llc anyway.
Okay, it makes sense to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100085/new/
https://reviews.llvm.org/D100085
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
