sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/FeatureModule.h:106
+ struct ASTListener {
+ virtual ~ASTListener() = default;
+
----------------
comment: listeners are destroyed once the AST is built.
================
Comment at: clang-tools-extra/clangd/FeatureModule.h:181
+/// Helper to get all the ast listeners available.
+std::vector<std::unique_ptr<FeatureModule::ASTListener>>
----------------
this seems like a slightly weird thing to have in FeatureModule.h, I'd be
tempted to inline it in the callsites instead, but up to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98499/new/
https://reviews.llvm.org/D98499
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
