njames93 added subscribers: aaron.ballman, rsmith. njames93 added inline comments.
================ Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { - assert(isPackExpansion() && "Initializer is not a pack expansion"); + if (!isPackExpansion()) + return {}; ---------------- steveire wrote: > njames93 wrote: > > I'm not sure about this change, but I'm guessing there's not a nice way to > > predicate these kinds of things > Yep. @rsmith @aaron.ballman Any issues with changing the contract of these functions to not assert for the purpose of this feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits