This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG95588c0da4ef: [clang][deps] NFC: Remove unused
FullDependencies member (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D100536?vs=337660&id=338500#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100536/new/
https://reviews.llvm.org/D100536
Files:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
Index: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
===================================================================
--- clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
+++ clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
@@ -16,10 +16,10 @@
std::vector<std::string> FullDependencies::getAdditionalCommandLine(
std::function<StringRef(ModuleID)> LookupPCMPath,
std::function<const ModuleDeps &(ModuleID)> LookupModuleDeps) const {
- std::vector<std::string> Ret = AdditionalNonPathCommandLine;
-
- Ret.push_back("-fno-implicit-modules");
- Ret.push_back("-fno-implicit-module-maps");
+ std::vector<std::string> Ret{
+ "-fno-implicit-modules",
+ "-fno-implicit-module-maps",
+ };
std::vector<std::string> PCMPaths;
std::vector<std::string> ModMapPaths;
Index: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
===================================================================
--- clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
+++ clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
@@ -38,13 +38,6 @@
/// determined that the differences are benign for this compilation.
std::vector<ModuleID> ClangModuleDeps;
- /// A partial addtional set of command line arguments that can be used to
- /// build this translation unit.
- ///
- /// Call \c getFullAdditionalCommandLine() to get a command line suitable for
- /// appending to the original command line to pass to clang.
- std::vector<std::string> AdditionalNonPathCommandLine;
-
/// Get additional arguments suitable for appending to the original Clang
/// command line.
///
Index: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
===================================================================
--- clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
+++ clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
@@ -16,10 +16,10 @@
std::vector<std::string> FullDependencies::getAdditionalCommandLine(
std::function<StringRef(ModuleID)> LookupPCMPath,
std::function<const ModuleDeps &(ModuleID)> LookupModuleDeps) const {
- std::vector<std::string> Ret = AdditionalNonPathCommandLine;
-
- Ret.push_back("-fno-implicit-modules");
- Ret.push_back("-fno-implicit-module-maps");
+ std::vector<std::string> Ret{
+ "-fno-implicit-modules",
+ "-fno-implicit-module-maps",
+ };
std::vector<std::string> PCMPaths;
std::vector<std::string> ModMapPaths;
Index: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
===================================================================
--- clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
+++ clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
@@ -38,13 +38,6 @@
/// determined that the differences are benign for this compilation.
std::vector<ModuleID> ClangModuleDeps;
- /// A partial addtional set of command line arguments that can be used to
- /// build this translation unit.
- ///
- /// Call \c getFullAdditionalCommandLine() to get a command line suitable for
- /// appending to the original command line to pass to clang.
- std::vector<std::string> AdditionalNonPathCommandLine;
-
/// Get additional arguments suitable for appending to the original Clang
/// command line.
///
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
