thopre added inline comments.
================ Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} } ---------------- ChuanqiXu wrote: > I find NSS2 equals to NSS0, which is `#0`. It looks good to me if this could > handle the inconsistency. Only without split stack (second RUN line). With split stack I get: ``` ; Function Attrs: noinline nounwind optnone uwtable mustprogress define dso_local i32 @_Z3foov() #0 { entry: ret i32 0 } ; Function Attrs: noinline optnone uwtable mustprogress define dso_local i32 @_Z7nosplitv() #1 { entry: %call = call i32 @_Z8tnosplitIiEiv() ret i32 %call } ; Function Attrs: noinline nounwind optnone uwtable mustprogress define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #2 comdat { entry: ret i32 0 } ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits