MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land.
With a nit ================ Comment at: clang/test/Driver/linux-cross.cpp:16 +/// We set explicit -ccc-install-dir ensure that Clang does not pick up extra +/// library directories which may be present in some build configuration. // DEBIAN_X86_64: "-L ---------------- Rather than `in some build configuration.`, just mention the configuration explicitly. No need to worry the information gets stale, people can dig up the history if the configuration changes. With `some build configuration`, future people cannot know and may defensively add `-ccc-install-dir` everywhere, which is not what we want for these driver tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101023/new/ https://reviews.llvm.org/D101023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
