MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:1425 + }; + return std::find(ValidRegs.begin(), ValidRegs.end(), RegName.upper()) != + ValidRegs.end(); ---------------- We should avoid static constructors/destructors if possible. Just use a plain array and `llvm::find(ValidRegs, RegName)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
