TaoPan marked an inline comment as done. TaoPan added a comment. Thanks Pengfei for your review comments!
================ Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 + if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); + if (TLI->getSchedulingPreference() == Sched::Linearize) + return createDAGLinearizer(IS, OptLevel); ---------------- pengfei wrote: > I saw they are always registered in ScheduleDAGFast.cpp: > https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp#L36 > Why do we register them again here? Please also help to have a review of the Summary. It's a little bit of a trick. ScheduleDAGFast.cpp is compiled to object file, but the object file isn't linked into clang executable file as no symbol is referred by outside without this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
