hokein added inline comments.
================ Comment at: clang/lib/Lex/PPDirectives.cpp:3026 const bool ConditionalTrue = DER.Conditional; + // Lexer might become invalid if we hit code completion point while evulating + // expression. ---------------- evulating => evaluating IIUC, `CurPPLexer` may be reset to nullptr after the above `EvaluateDirectiveExpression` call? If so, I think there is another place having the same pattern, line 597 of this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102069/new/ https://reviews.llvm.org/D102069 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
