aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the single quotes in the diagnostic.
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548 +def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet supported on AIX">; + ---------------- aaron.ballman wrote: > This neatly avoids the problem of diagnostics not starting with a capital > letter (it looks like we have other diagnostics to update, but that's not > your problem to deal with). Can you also add the single quotes around the %0 so that the diagnostic is properly quoted? ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3154 +def err_aix_attr_unsupported_tls_model : Error<"The tls model %0 is not yet supported on AIX">; + ---------------- aaron.ballman wrote: > Same here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
