MaskRay marked an inline comment as done.
MaskRay added a comment.
In D102090#2749473 <https://reviews.llvm.org/D102090#2749473>, @rnk wrote:
> +1 to the idea, but I have no idea if this is the right cmake spot
>
> If we've decided to actually care about the shared library build, should we
> also consider using `-fvisibility-inlines-hidden`?
Line 329: `check_cxx_compiler_flag("-fvisibility-inlines-hidden"
SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG)`.
llvm-project has been using this since 2012. With this flag, taking the address
of an inline function may be different in different modules.
So -fno-semantic-interposition and -Bsymbolic-functions will now complement the
existing option:)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102090/new/
https://reviews.llvm.org/D102090
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
