foad added a comment. Can you also check for updates in: clang/lib/Basic/Cuda.cpp openmp/libomptarget/plugins/amdgpu/impl/get_elf_mach_gfx_name.cpp llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll llvm/test/tools/llvm-objdump/ELF/AMDGPU/subtarget.ll llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:4489 case CudaArch::GFX1033: + case CudaArch::GFX1034: case CudaArch::UNUSED: ---------------- I think lint is complaining about trailing whitespace here -- please check the whole patch for it. ================ Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:334 +# ELF-AMDGCN-GFX1034: EF_AMDGPU_MACH_AMDGCN_GFX1034 (0x3E) +# YAML-AMDGCN-GFX1034: Flags: [ EF_AMDGPU_MACH_AMDGCN_GFX1034 ] ---------------- You also need to add RUN lines at the top of this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits