ychen added inline comments.
================
Comment at: clang/include/clang/AST/StmtCXX.h:356-359
Expr *Allocate = nullptr;
Expr *Deallocate = nullptr;
+ Expr *AlignedAllocate = nullptr;
+ Expr *AlignedDeallocate = nullptr;
----------------
ChuanqiXu wrote:
> ychen wrote:
> > ChuanqiXu wrote:
> > > Can't we merge these?
> > I'm not sure about the "merge" here. Could you be more explicit?
> Sorry. I mean if we can merge `Allocate` with `AlignedAllocate` and merge
> `Deallocate` with `AlignedDeallocate`. Since from the implementation, it
> looks like the value of `Allocate` and `AlignedAllocate ` (so as `Deallocate`
> and `AlignedDeallocate`) are the same.
Oh, this is to set the path for D102147 where `Allocate` and `AlignedAllocate`
could be different. If I do this in D102147, it will also touch the
`CGCoroutine.cpp` which I'm trying to avoid` since it is intended to be a Sema
only patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97915/new/
https://reviews.llvm.org/D97915
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
