Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). ================ Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:8 @@ +7,3 @@ +------------------ +This check is to warn about the performance overhead arising from concatenating strings, using the operator+, for instance: + ---------------- Please highlight operator+ and other class/methods with ``. Same for other places in documentation. ================ Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:21 @@ +20,3 @@ + + std::string a = "Foo", b = "Baz"; + for(int i = 0; i < 20000; ++i) ---------------- Please use constructor initialization instead of assignment. ================ Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:58 @@ +57,1 @@ + } \ No newline at end of file ---------------- Please add new line. ================ Comment at: test/clang-tidy/performance-inefficient-string-addition.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s performance-inefficient-string-addition %t -- -- -std=c++11 + ---------------- Does it really need to be C++11? ================ Comment at: test/clang-tidy/performance-inefficient-string-addition.cpp:45 @@ +44,1 @@ +} \ No newline at end of file ---------------- Please add new line. http://reviews.llvm.org/D20196 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
