dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
Looks good, thanks! Probably skip the other two in_place_* until we have a use for them. ================ Comment at: llvm/include/llvm/ADT/STLForwardCompat.h:53-73 + +template <typename T> +struct in_place_type_t // NOLINT(readability-identifier-naming) +{ + explicit in_place_type_t() = default; +}; +/// \warning This must not be odr-used, as it cannot be made \c inline in C++14. ---------------- I'd probably skip these until we have a use for them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100671/new/ https://reviews.llvm.org/D100671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits