myhsu added a comment. In D102585#2769887 <https://reviews.llvm.org/D102585#2769887>, @nickdesaulniers wrote:
> Looking good @myhsu . Also, I got your LLVM book recently! You'll need to > sign it for me at the next llvm conf in person. Thank you :-) Hope you will like it. I'll start to practice my autograph too. ================ Comment at: clang/test/Sema/inline-asm-validate-m68k.c:51 + asm volatile ("" :: "C0"(IncorrectVal)); // expected-error{{value '1' out of range for constraint 'C0'}} +} ---------------- nickdesaulniers wrote: > do we need tests for lowercase `a`, `r`, or `d`? Actually I think `r` is already a built-in constraint letter for register. I'm adding test cases for `a` and `d` though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits