mstorsjo added a comment. In D102812#2773132 <https://reviews.llvm.org/D102812#2773132>, @DavidSpickett wrote:
>> Updated to allow mismatches and just picking the value that is set last on >> the command line - what do you think of this version? > > My initial reaction was that I'd prefer to take the last one that matches the > input type, to be consistent with `-march` and `-mcpu`. `march` and `mcpu` > effect both so it makes sense to switch on the input type. > However this is an option that only effects asm/inline asm (even when passed > as a compiler option) so you could think of `-mimplicit-it` as an alias to > `-Wa,-mimplicit-it`. So taking the last value we find sounds good to me. > > Ideally we would warn about conflicting values but that's an enhancement that > can be done another time if we see situations where it could have been useful. Thanks for your input! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102812/new/ https://reviews.llvm.org/D102812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
