dexonsmith added a comment. Naively, this sounds like it could be a non-trivial tax on build times. But it looks like it's only called in Clang from `Sema::diagnoseMissingImport`, which only happens on error anyway.
================ Comment at: clang/unittests/Lex/HeaderMapTest.cpp:9 -#include "clang/Basic/CharInfo.h" -#include "clang/Lex/HeaderMap.h" -#include "clang/Lex/HeaderMapTypes.h" +#include "HeaderMapTestUtils.h" #include "llvm/ADT/SmallString.h" ---------------- Splitting this out seems like a great idea, but please split it out to a separate prep commit that's NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
