amccarth added inline comments. ================ Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector<uint8_t> VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, ---------------- majnemer wrote: > It might be nicer to use a `SmallVector<uint8_t, sizeof(VS_FIXEDFILEINFO)>`, > or whatever `VersionSize` typically is, here to avoid heap allocation in the > common case. What's the cutoff for "small"? The version block in cl.exe is about 9KB.
http://reviews.llvm.org/D20136 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
