ASDenysPetrov added a comment.

@NoQ

> I guess another option is to put `loc::MemRegionVal()` inside `castRegion()`. 
> This way the return type `Optional<loc::MemRegionVal>` unambigously tells 
> that the region is always non-null if present (protected by the assertion in 
> the constructor of `loc::MemRegionVal`).

IMO we should keep `const MemRegion *` for `castRegion` as is, since it's 
intended for //cast// and should behave as //cast//. I'd better add a kinda 
wrapper`SValBuilder::getCastedMemRegionVal`. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103319/new/

https://reviews.llvm.org/D103319

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to