arames added inline comments.
================ Comment at: clang/include/clang/Basic/Sanitizers.h:81 + template <typename HashT> void updateHash(HashT &Hash) const { + Hash.updateRange(&maskLoToHigh[0], &maskLoToHigh[0] + kNumElem); ---------------- An alternative to having those in class would be to have helpers directly in `CompilerInvocation.cpp`. I decided to keep them here for two reasons: 1. Keep them next to `hash_value`, to make it clear they need to be updated as well. 2. At least this class does not have all elements going into the hash `public`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits