jcai19 added a comment. In D103184#2798398 <https://reviews.llvm.org/D103184#2798398>, @DavidSpickett wrote:
>> LGTM; any additional thoughts @DavidSpickett ? > > A couple of additional tests just to be safe but otherwise LGTM. > > Also please include in the commit message the "rules" that we're using here > for parsing. Like I did for the arm change. Thanks all! ================ Comment at: clang/test/Driver/aarch64-target-as-march.s:29 +// RUN: FileCheck --check-prefix=MULTIPLE-VALUES %s + +// MULTIPLE-VALUES: "-target-feature" "+v8.1a ---------------- DavidSpickett wrote: > Add a test with `-Wa,-march=armv8.2-a,-march=armv8.1-a` (one -Wa with > multiple values attached), then repeat the two tests but with `-Xassembler` > instead. I added a test case for -Xassembler -march=armv8.2-a,-march=armv8.1-a, but it seems it does not support multiple values in one invocation? clang --target=aarch64-linux-gnueabi -Xassembler -march=armv8.2-a,-march=armv8.1-a -c foo.s -o ias.o -### ... clang-13: error: the clang compiler does not support '-Xassembler -march=armv8.2-a,-march=armv8.1-a' ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
