pcc added a comment. In D103845#2806211 <https://reviews.llvm.org/D103845#2806211>, @leonardchan wrote:
> In D103845#2804441 <https://reviews.llvm.org/D103845#2804441>, @pcc wrote: > >> This isn't how the output looks on Android. Are you sure this isn't a >> Fuchsia-specific bug in the output formatting? > > I think the newline gets added to the frame description only if > `Symbolizer::GetOrInit()->SymbolizePC(pc)` is nonnull, so if it fails then no > newline is added. I see. I guess we never tested the code path where `SymbolizePC` returned null on Android. I think I would prefer doing this in a slightly different way where the `\n` gets added in the Printf call on line 244. Then you can remove the `\n` on line 239 and you shouldn't need the else clause. Where does the `{{{bt:0:0x214178819a54}}}`come from on Fuchsia? Is it printed to the console as a side effect of calling `SymbolizePC`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103845/new/ https://reviews.llvm.org/D103845 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
