Meinersbur marked an inline comment as done. Meinersbur added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); + Factor = + cast<llvm::ConstantInt>(FactorRVal.getScalarVal())->getZExtValue(); + assert(Factor >= 1 && "Only positive factors are valid"); ---------------- ABataev wrote: > ABataev wrote: > > I suppose it is compiled-time expression, right? If so, use > > `FactorExpr->EvaluateKnownConstInt()` or something similar. > Not done. It was done in another branch that I forgot to merge. Sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
