davrec added a comment. Was this performance hit when using the static analyzer? A quick search suggests `isAnyDestructorNoReturn()` is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (`hasIrrelevantDestructor()` etc.) seem to be called somewhere by Sema.
So non-users of the analyzer would not benefit from this change, and will incur a slight cost, IIUC. Is that cost remotely noticeable? Probably not, but a quick test along those lines would be helpful. All in all this is probably good and advisable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104182/new/ https://reviews.llvm.org/D104182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
