jansvoboda11 added a comment.

In D103930#2825181 <https://reviews.llvm.org/D103930#2825181>, @dexonsmith 
wrote:

> In D103930#2820725 <https://reviews.llvm.org/D103930#2820725>, @bruno wrote:
>
>> Thanks for working on this, comments inline. @vsapsai @jansvoboda11 
>> @dexonsmith any headermap related concerns on your side?
>
> @jansvoboda11, I think it'd be prudent for us to test this patch out 
> internally before it's landed, since I don't really trust that the existing 
> unit tests cover all the interactions between header maps and modules. Might 
> you be able to coordinate something with @arphaman?

I'm OOO until July 7. @arphaman, can you take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103930/new/

https://reviews.llvm.org/D103930

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to