kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918 + // from the index, we reduce the noise in all the other completion scopes. + if (llvm::isa<ObjCCategoryDecl>(&ND)) + return false; ---------------- dgoldman wrote: > Seems like we should also ignore ObjCCategoryImplDecl, I think those would > have the same issue (although only from other .m files in the project, not > from SDK headers)? we actually never index those, as symbolcollector canonicalizes ObjcCategoryImplDecls to ObjcCategoryDecl, so we can't really test it. but adding here for completeness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104540/new/ https://reviews.llvm.org/D104540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
