hokein marked an inline comment as done.
================
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa<UnresolvedLookupExpr>(Node.getCallee());
+}
----------------
alexfh wrote:
> I think, we should use a node matcher for `UnresolvedLookupExpr` and instead
> use `callExpr(callee(unresolvedLookupExpr().bind("something")))`.
>
> Also, I would create the new matcher in the ASTMatchers.h right away,
> together with a test and docs. But if you want this patch to be in soon, feel
> free to move the matcher to the matchers library in a follow up.
Agree. I will add a node matcher for `UnresolvedLookupExpr` in a follow-up
patch.
http://reviews.llvm.org/D20326
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
