tra accepted this revision. tra added a comment. LGTM. Would you like me to land the patch on your behalf?
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16397 unsigned NumEltsD; std::array<unsigned, 8> Variants; ---------------- A comment here describing expected arrangement of the variants here would be helpful. E.g. `ordered by layout-A/layout-B/satf, where 'row' has priority over 'col' for layout. The index of non-satf variants is expected to match the undocumented layout constants used by CUDA's mma.hpp`. It could be cleaner if we could use designated initializer, but we can't use them yet until LLVM switches to c++20. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104847/new/ https://reviews.llvm.org/D104847 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
