lxfind added a comment. In D95807#2846358 <https://reviews.llvm.org/D95807#2846358>, @ChuanqiXu wrote:
>> note that we don't really need to run Inliner again on the ramp function >> after split > > This isn't accurate. The inline may run again for ramp function after split > and it's required by coro elide. If there is an inlining opportunity, it should have happened pre-split, right? Is there any reason it didn't happen pre-split but only post-split? > It seems like that we don't need the attribute `CORO_PRESPLIT_ATTR` any more, > do we? If yes, I think we should remove them. It's still needed by the legacy pass manager. I don't want to break that yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95807/new/ https://reviews.llvm.org/D95807 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
