craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:748
bool hasVLX() const { return HasVLX; }
+ bool hasFP16() const { return HasFP16; }
bool hasPKU() const { return HasPKU; }
----------------
pengfei wrote:
> RKSimon wrote:
> > I'm a little worried this might get confused with hasF16C - am I just being
> > over cautious?
> Make sense. How about `hasAVX512FP16`? I can update the name as a followup
> patch once these patches merged.
That sounds good to me. We should maybe go back and update some of the others.
Especially VNNI since we also have AVXVNNI.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105263/new/
https://reviews.llvm.org/D105263
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
