cjdb created this revision. Herald added subscribers: usaxena95, kadircet, jfb, arphaman. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.
Compiling clangd with Clang modules and libc++ revealed that `support/Threading.h` uses `std::atomic` but wasn't including the correct header. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105400 Files: clang-tools-extra/clangd/support/Threading.h Index: clang-tools-extra/clangd/support/Threading.h =================================================================== --- clang-tools-extra/clangd/support/Threading.h +++ clang-tools-extra/clangd/support/Threading.h @@ -12,6 +12,7 @@ #include "support/Context.h" #include "llvm/ADT/FunctionExtras.h" #include "llvm/ADT/Twine.h" +#include <atomic> #include <cassert> #include <condition_variable> #include <future>
Index: clang-tools-extra/clangd/support/Threading.h =================================================================== --- clang-tools-extra/clangd/support/Threading.h +++ clang-tools-extra/clangd/support/Threading.h @@ -12,6 +12,7 @@ #include "support/Context.h" #include "llvm/ADT/FunctionExtras.h" #include "llvm/ADT/Twine.h" +#include <atomic> #include <cassert> #include <condition_variable> #include <future>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
