cjdb added a comment.

A few notes to reviewers:

- The patch assumes everything is under a top-level `__libcxx` directory, 
because it seems there are other system headers that could be prefixed with 
`__`. libc++ currently has many top-level directories, following the trend of 
`__${STD_LIB_HEADER}/`. I see two solutions going forward:
  1. libc++ moves everything into a top-level `__libcxx` directory, which 
minimises the chances of clashing with pre-existing top-level directories that 
we don't own. Once this patch is committed, it probably won't need to be 
updated (sans bug fixes).
  2. This patch adopts a set of "blessed" directories that needs to be 
consistently updated as we splice more and more headers (and as WG21 adds more 
headers to C++).
- The patch could probably do with more testing, but I'm coming up dry :-(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105439/new/

https://reviews.llvm.org/D105439

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to