aaron.ballman added a comment. In D69764#2863312 <https://reviews.llvm.org/D69764#2863312>, @steveire wrote:
> In D69764#2863266 <https://reviews.llvm.org/D69764#2863266>, @aaron.ballman > wrote: > >> In D69764#2863213 <https://reviews.llvm.org/D69764#2863213>, @steveire wrote: >> >>> @MyDeveloperDay Does anything prevent this being merged, instead of just >>> rebased? >> >> Please see my comments from https://reviews.llvm.org/D69764#2533538. > > A clang-tidy check will never be as fast as clang-query. > > Anyway, you're against merging this, but there are clearly many people who > prefer to see it merged. Can we merge it? No. My concerns are with the fact that this feature can break working code and there's significant value in being able to trust your code formatting tool will not do that. That sentiment has been expressed by others as a matter of concern for them as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
